rawnar Posted June 3, 2010 Share Posted June 3, 2010 While checking the plugin for Borderlands with my friend we found out that his plugins were not updated. To be more precise his Roaming\mumble\plugins directory was completely empty. This could be due to his for gaming optimized version of windows, that lacks some functionality needed by mumble.Me and my want to fix it all attitude went into the source of mumble to find this functionality that he could be missing. And quickly within the Plugins.cpp file I found the WinVerifyTrust() function that asks the trust provider if a file can be trusted. Probably the provider is missing on his system and function will not return a zero. Could this part be changes so it also checks the possibility that there is something wrong with the trust provider and handle appropriately?While reading the documentation of WinVerifyTrust on MSDN I came across this note:The return value is a LONG, not an HRESULT as previously documented. Do not use HRESULT macros such as SUCCEEDED to determine whether the function succeeded. Instead, check the return value for equality to zero.In Mumble the return value is declared HRESULT, maybe as a precaution this has to be changed to LONG WINAPI. The return value is checked for being zero, so that is consistent with the note. Computer specs: AMD FX-8320, 8GB DDR3-SDRAM, AMD Radeon HD 7950, Asus Xonar D1, Windows 7 Ultimate 64bit/Debian Jessie AMD64. Link to comment Share on other sites More sharing options...
Please sign in to comment
You will be able to leave a comment after signing in
Sign In Now