Jump to content
Mumble forums

How is Priority Speaker supposed to work?


realnc
 Share

Recommended Posts

I found a problem with the “priority speaker” thingy. It doesn’t work :P When I try it on myself, only I can hear a difference in other people’s volume.


How is it supposed to work? Doesn’t this come from the server? Do all people need to connect with Mumble 1.2.3? If yes, how can I only allow people with 1.2.3 or higher to connect to the server?


The Murmur server is 1.2.3 RC.

Link to comment
Share on other sites

  • Moderators

The server does no processing of the audio data and the volume change is done on the client, only 1.2.3 clients will hear a difference.


Limiting the server to 1.2.3 clients would require an Ice script or a modified server version.

Link to comment
Share on other sites

The server does no processing of the audio data and the volume change is done on the client, only 1.2.3 clients will hear a difference.


Limiting the server to 1.2.3 clients would require an Ice script or a modified server version.

Do you have any info on how to modify the server to accept only 1.2.3+?

Link to comment
Share on other sites

  • Moderators

This patch (or something similar) should work:

 

diff --git a/src/murmur/Messages.cpp b/src/murmur/Messages.cpp
index a682691..4f0d7ea 100644
--- a/src/murmur/Messages.cpp
+++ b/src/murmur/Messages.cpp
@@ -188,6 +188,12 @@ void Server::msgAuthenticate(ServerUser *uSource, MumbleProto::Authenticate &msg
               ok = false;
       }

+       if (uSource->uiVersion < 0x010203) {
+               reason = QString::fromLatin1("An 1.2.3 or newer client is required to connect to this server");
+               rtType = MumbleProto::Reject_RejectType_WrongVersion;
+               ok = false;
+       }
+
       if (! ok) {
               log(uSource, QString("Rejected connection: %1").arg(reason));
               MumbleProto::Reject mpr;

Link to comment
Share on other sites

  • Administrators

An alternative to patching and compiling the server would be to use an ice callback.

http://mumble.sourceforge.net/slice/Murmur/ServerCallback.html#userConnected

Although I do wonder now if you can even disconnect that user … Probably not.

So the Server patch is probably the best / only way to do it. Especially as it also gives a reason the user will understand / can read.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...